Re: [Emacs-diffs] trunk r117007: Optimize cl-struct-slot-value; fix test

[Daniel Colascione]

On 04/21/2014 09:34 PM, Stefan Monnier wrote:
>> -  (elt inst (cl-struct-slot-offset struct-type slot-name)))
>> +  ;; We could use `elt', but since the byte compiler will resolve the
>> +  ;; branch below at compile time, it's more efficient to use the
>> +  ;; type-specific accessor.
>> +  (if (eq (cl-struct-sequence-type struct-type) 'vector)
>> +      (aref inst (cl-struct-slot-offset struct-type slot-name))
>> +    (nth (cl-struct-slot-offset struct-type slot-name) inst)))
> 
> It won't always resolve the (eq (cl-struct-sequence-type struct-type)
> 'vector) test at compile-time, tho.

It did in my tests, when struct-type was a symbol. When struct-type is
something that might vary, the branch shows up in the bytecode. Maybe
the comment should say "will resolve...when possible".

signature.asc
Description: OpenPGP digital signature