emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] emacs-24 r117079: * minibuf.c (read_minibuf): Avoid C9


From: Stefan Monnier
Subject: Re: [Emacs-diffs] emacs-24 r117079: * minibuf.c (read_minibuf): Avoid C99ism in previous patch.
Date: Wed, 07 May 2014 20:41:54 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux)

> +  Lisp_Object histval;
 
>    Lisp_Object empty_minibuf;
>    Lisp_Object dummy, frame;
> @@ -536,11 +537,12 @@
>      Vminibuffer_completing_file_name = Qlambda;
 
>    /* If variable is unbound, make it nil.  */
> -  Lisp_Object histval = find_symbol_value (Vminibuffer_history_variable);
> -  if (EQ (histval, Qunbound)) {
> -    Fset (Vminibuffer_history_variable, Qnil);
> -    histval = Qnil;
> -  }
> +  histval = find_symbol_value (Vminibuffer_history_variable);

Please keep the initialization together with the declaration
whenever possible (such as here).


        Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]