|
From: | Stefan Monnier |
Subject: | Re: [Emacs-diffs] trunk r117464: Shrink Lisp_Sub_Char_Table by preferring C integers to Lisp_Objects. |
Date: | Thu, 03 Jul 2014 09:57:00 -0400 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) |
>> But the problem is that the code is vulnerable to these kinds >> of changes. Why do we even need to treat such a Lisp_Sub_Char_Table as >> a Lisp_Vector at all? I don't see any real need for it. > This is somewhat similar to r110830 when we shrink struct vectorlike_header. I'm not arguing against your optimization. While I don't think it's important, I'm perfectly happy if you work on such things. But I don't see why that necessarily implies casting Lisp_Sub_Char_Table to a Lisp_Vector (I ask this question without having spent much time looking for the answer in the source, maybe the answer is obvious, but I think if you can tell me why it's a better use of my time than trying to figure it out myself). Stefan
[Prev in Thread] | Current Thread | [Next in Thread] |