emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [elpa] 04/07: diff-hl-mode: defer diff-hl-update until diff-hl-mode-


From: Stefan Monnier
Subject: Re: [elpa] 04/07: diff-hl-mode: defer diff-hl-update until diff-hl-mode-on-hook
Date: Sun, 10 Aug 2014 12:45:33 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux)

> +        (add-hook (if vc-mode
> +                      'diff-hl-mode-on-hook
> +                    'find-file-hook)
> +                  'diff-hl-update t t)

I think this deserves a comment (both for the use of a hook, and for the
use of a different hook depending on vc-mode).

>          (add-hook 'after-revert-hook 'diff-hl-update nil t)
>          (add-hook 'magit-revert-buffer-hook 'diff-hl-update nil t)

And I think this deserves a comment as well explaining why
after-revert-hook doesn't already cover the magit case.


        Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]