emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Benchmarking temporary Lisp objects [Was: Re: [RFC] temporary Lisp_S


From: Dmitry Antipov
Subject: Re: Benchmarking temporary Lisp objects [Was: Re: [RFC] temporary Lisp_Strings]
Date: Fri, 05 Sep 2014 08:00:33 +0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0

On 09/04/2014 08:03 PM, Paul Eggert wrote:

For vectors the macro needs to generate a series of declarations and
statements  rather than an expression.  It's less clean, but it's good
enough.  Something like the attached, say.

IMO this is a bit overengineered.  In particular, the whole thing is to
allocate short-lived objects which are usually small. This means that
!issmall branch is unlikely to be taken but requires SAFE_xxx anyway.
Moreover, I think we need a very special benchmark to see a difference
between alloca and VLA (if any), thus using the latter at any cost doesn't
worth an extra complexity.  So, although I have no strong objections
about your version, I'm voting for simpler and cleaner version with
alloca/fallback to regular GC for vectors and strings.  Stefan?

Dmitry


Attachment: local_objects.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]