[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] trunk r117846: Add macros to allocate temporary Lisp o
|
From: |
Stefan Monnier |
|
Subject: |
Re: [Emacs-diffs] trunk r117846: Add macros to allocate temporary Lisp objects with alloca. |
|
Date: |
Tue, 09 Sep 2014 09:13:38 -0400 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) |
> --- a/src/lisp.h 2014-09-07 07:04:01 +0000
> +++ b/src/lisp.h 2014-09-09 03:44:06 +0000
> @@ -298,6 +298,13 @@
> # endif
> #endif
>
> +/* Stolen from gnulib. */
> +#if (__GNUC__ || __HP_cc || __HP_aCC || __IBMC__ \
> + || __IBMCPP__ || __ICC || 0x5110 <= __SUNPRO_C)
> +#define GCALIGNED __attribute__ ((aligned (GCALIGNMENT)))
> +#else
> +#define GCALIGNED /* empty */
> +#endif
Any reason you don't use the `alignas' we already use/check just above?
> +#if (__GNUC__ || __HP_cc || __HP_aCC || __IBMC__ \
> + || __IBMCPP__ || __ICC || 0x5110 <= __SUNPRO_C)
Yuck! Why not check USE_LSB_TAG?
- USE_LSB_TAG is only set when we have alignas defined.
- When USE_LSB_TAG is not set, you don't need special alignment.
Stefan