emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] trunk r117846: Add macros to allocate temporary Lisp o


From: Dmitry Antipov
Subject: Re: [Emacs-diffs] trunk r117846: Add macros to allocate temporary Lisp objects with alloca.
Date: Wed, 10 Sep 2014 12:20:27 +0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0

On 09/10/2014 10:43 AM, Paul Eggert wrote:

I installed some changes that I hope improve things.

| (pointer_valid_for_lisp_object): Remove.  This check is not
| necessary, since make_lisp_ptr is already doing it.  All uses removed.

This is still in use in verify_alloca:

../../trunk/src/alloc.c: In function ‘verify_alloca’:
../../trunk/src/alloc.c:7179:7: error: implicit declaration of function 
‘pointer_valid_for_lisp_object’ [-Werror=implicit-function-declaration]
       eassert (pointer_valid_for_lisp_object (ptr));
       ^
../../trunk/src/alloc.c:7179:7: error: nested extern declaration of 
‘pointer_valid_for_lisp_object’ [-Werror=nested-externs]
cc1: all warnings being treated as errors

If you think that this function is redundant, feel free to remove it; otherwise 
let's use make_lisp_ptr.

Dmitry





reply via email to

[Prev in Thread] Current Thread [Next in Thread]