[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: trunk r117960: * etc/TODO: Add a few entries, remove others, expand
From: |
Dmitry Gutov |
Subject: |
Re: trunk r117960: * etc/TODO: Add a few entries, remove others, expand some |
Date: |
Tue, 30 Sep 2014 03:47:37 +0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 |
On 09/28/2014 08:24 PM, Stefan Monnier wrote:
Any particular reason for the removal of this item?
AFAIK it is now fixed.
Oh, that's great, thanks. Should the bugs be closed, then?
And the change be mentioned in NEWS? So that ELisp coders know starting
with which version of Emacs they don't need the workaround anymore.
-** Compute the list of active keymaps *after* reading the first event.
After all, at the end of bug#10459, you've called the current solution
an ugly hack.
That was not a solution in src.keyboard.c but a workaround in Toby's
Elisp code, IIUC. Since then the C code has been changed (see
src/keyboard.c:9310:
I just meant that as long as the recommended approach for how to do that
desired thing was a hack, the TODO item was still valid.
if (NILP (first_event))
{
first_event = key;
/* Even if first_event does not specify a particular
window/position, it's important to recompute the maps here
since a long time might have passed since we entered
read_key_sequence, and a timer (or process-filter or
special-event-map, ...) might have switched the current buffer
or the selected window from under us in the mean time. */
if (fix_current_buffer
&& (XBUFFER (XWINDOW (selected_window)->contents)
!= current_buffer))
Fset_buffer (XWINDOW (selected_window)->contents);
current_binding = active_maps (first_event);
}
Cool, it seems to have been changed right after the 24.3 release.