emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: eieio, pretty printing, and edebug


From: Eric Abrahamsen
Subject: Re: eieio, pretty printing, and edebug
Date: Wed, 29 Oct 2014 19:50:54 -0700
User-agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/24.4 (gnu/linux)

Stefan Monnier <address@hidden> writes:

>> objects to be a part of the "safety" routine -- would it be unreasonable
>> to make edebug aware of eieio, and move most of the logic of
>> `eieio-edebug-prin1-to-string' into `edebug-safe-prin1-to-string',
>> guarded by a `featurep'?
>
> I don't think it'd be better than using advice-add, actually.
>
> If you want it to be cleaner, the first step is to replace
> the edebug-prin1-to-string function with a variable
> edebug-prin1-to-string-function (so it's clear that it's meant to be
> changed), and hence to modify it with add-function rather than
> advice-add.
>
> The even better way, as mentioned earlier, is to change prin1's
> underlying infrastructure so eieio can hook into it.

I just put up a patch that does considerably less than all that. I can
probably manage solution number one above, but if you'd like to hold out
for solution number two, I'll bow out and leave the bug report for
others.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]