emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Whitespace in `${srcdir}' during `configure'


From: Glenn Morris
Subject: Re: Whitespace in `${srcdir}' during `configure'
Date: Mon, 10 Nov 2014 14:25:03 -0500
User-agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/)

Oh now, I see.

I guess you were using Emacs 24.4 or emacs-24.

In that branch

  . $srcdir/nt/mingw-cfg.site

indeed comes before "checking whether build environment is sane" (via
AM_SANITY_CHECK from AM_INIT_AUTOMAKE). In trunk, it comes after.

So in that branch, we should indeed either quote that one reference to
srcdir, or move it after AM_INIT_AUTOMAKE (that change was already made
in trunk 2014-06-10).

PS Quoting is not always necessary, eg it's not needed in case
arguments and on the RHS of assignments:

https://www.gnu.org/software/autoconf/manual/autoconf-2.67/html_node/Shell-Substitutions.html

So AFAICS none of the other changes you suggest would be necessary (even
if srcdir could contain spaces) apart from the gdbinit one. But by that
stage, we are sure srcdir has no spaces.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]