Re: porting to Wayland

[Daiki Ueno]

Jan Djärv <address@hidden> writes:

> Ok, here goes.

Thanks!

> Image support sucks, only PNG from files.  Some redraw issues
> (esp. Gtk scrollbars) remain.
> If you choose Gtk3 as toolkit, cairo is forced, otherwise
> give--with-cairo to configure.

I've tried the patch.  For PNG support, I had to apply the attached
patch and run configure with:

  ./configure --with-x-toolkit=gtk3 --with-cairo --without-imagemagick

The output for printing (with x-export-frames) looks great.  

> Performance is not that great, straight X is faster.

It's already fast enough for me, but it doesn't do rendering in ::draw
signal, right?  If it did, would the speed considerablly slow down?

Regards,
--
Daiki Ueno

diff --git a/configure.ac b/configure.ac
index ac0b86e..a84637d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3042,7 +3042,6 @@ if test "${HAVE_X11}" = "yes"; then
     fi
     with_xpm=no
     with_jpeg=no
-    with_png=no
     with_gif=no
     with_tiff=no
 
diff --git a/src/image.c b/src/image.c
index 77e5523..ad31719 100644
--- a/src/image.c
+++ b/src/image.c
@@ -5459,7 +5459,7 @@ pbm_load (struct frame *f, struct image *img)
                                 PNG
  ***********************************************************************/
 
-#if defined (HAVE_XPM) || defined (HAVE_NS) || defined (USE_CAIRO)
+#if defined (HAVE_PNG) || defined (HAVE_NS) || defined (USE_CAIRO)
 
 /* Function prototypes.  */