emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: cl-macro-expandall symbol definition is void


From: Glenn Morris
Subject: Re: cl-macro-expandall symbol definition is void
Date: Tue, 25 Nov 2014 17:35:46 -0500
User-agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/)

Following diff seems to make csharp-mode-0.8.5.el work fine for me.
(Without the `eval-and-compile', it was uncompilable in any Emacs 24.x.)

Since it uses eg `set-difference', IMO it should in any case explicitly
require cl and not rely on its other dependencies pulling it in.

*** csharp-mode-0.8.5.el.ORIG   2014-11-25 14:32:22.001787092 -0800
--- csharp-mode-0.8.5.el        2014-11-25 14:31:13.608157922 -0800
***************
*** 379,384 ****
--- 379,385 ----
  ;;    0.8.6 DPC 2011 May ??
  ;;          -
  
+ (eval-when-compile (require 'cl))
  
  (require 'cc-mode)
  
***************
*** 472,477 ****
--- 473,479 ----
    "Regex for matching directive blocks in ASP.NET files (.aspx, .ashx, 
.ascx)")
  
  
+ (eval-and-compile
  (defconst csharp-enum-decl-re
    (concat
     "\\<enum[ \t\n\r\f\v]+"
***************
*** 484,490 ****
     "\\)"
     "\\)?")
    "Regex that captures an enum declaration in C#"
!   )
  
  ;; ==================================================================
  
--- 486,492 ----
     "\\)"
     "\\)?")
    "Regex that captures an enum declaration in C#"
!   ))
  
  ;; ==================================================================
  



reply via email to

[Prev in Thread] Current Thread [Next in Thread]