emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Minor Patch: Respect browse-url-new-window-flag


From: Lars Magne Ingebrigtsen
Subject: Re: Minor Patch: Respect browse-url-new-window-flag
Date: Mon, 01 Dec 2014 05:04:31 +0100
User-agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux)

"T. V. Raman" <address@hidden> writes:

> Here is a simple patch to eww.el to respect option
> browse-url-new-window-flag
> git diff master -- eww.el
> diff --git a/lisp/net/eww.el b/lisp/net/eww.el
> index 2059b5e..4613b4c 100644
> --- a/lisp/net/eww.el
> +++ b/lisp/net/eww.el
> @@ -680,7 +680,7 @@ the like."
>
>  ;;;###autoload
>  (defun eww-browse-url (url &optional new-window)
> -  (cond (new-window
> +  (cond ((or browse-url-new-window-flagnew-window)

I don't think that's appropriate.  browse-url says whether to open a new
window when you're opening an URL outside of a browser, not what the
browser should do once you've opened it.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



reply via email to

[Prev in Thread] Current Thread [Next in Thread]