emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Generators (iterators) for Gnu Emacs


From: Stefan Monnier
Subject: Re: Generators (iterators) for Gnu Emacs
Date: Fri, 05 Dec 2014 09:40:33 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux)

> No.  Daniel's package https://github.com/dcolascione/elisp-generators.
> Do you have time to critique the code and make it an integral part of
> elisp? Thanks ;)

I haven't had time to look at it in detail, but it looks nice.
Things I noticed:
- Drop the use of (require 'cl).
- Use `declare' for indentation and edebug specs.
- Most importantly: clean up the namespace use.  `yield' is probably OK
  (tho the global definition should probably not override a previous
  definition) but `next' needs to turn into something like `gen-next',
  `do-iterator' should probably turn into `gen-do', cl-loop's
  `iterating' should probably turn into something that includes
  "generator" in its name, `lambda-generator' should maybe be renamed to
  `gen-lambda', ...

Once that's fixed, I'd be happy to see it included in Emacs.


        Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]