emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: dired: make dired-maybe-insert-subdir always skip trivial files


From: Filipp Gunbin
Subject: Re: dired: make dired-maybe-insert-subdir always skip trivial files
Date: Thu, 25 Dec 2014 22:51:10 +0300
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (darwin)

On 25/12/2014 21:32 +0200, Juri Linkov wrote:

>> -         (dired-goto-subdir dirname))
>> +         (when (dired-goto-subdir dirname)
>> +           (unless (dired-subdir-hidden-p dirname)
>> +             (dired-initial-position dirname))
>> +           t))
>
> Why do you always return t?  Wouldn't it be better to use something like
> (prog1 (dired-goto-subdir dirname) (unless ...))

This way, (unless ...) will be evaluated even if `dired-goto-subdir'
returned nil.

Filipp



reply via email to

[Prev in Thread] Current Thread [Next in Thread]