emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: #2 [Was: Re: Function attributes for make-docfile]


From: Stefan Monnier
Subject: Re: #2 [Was: Re: Function attributes for make-docfile]
Date: Thu, 15 Jan 2015 00:33:34 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux)

> Assuming --enable-gcc-warnings, it's a combination of things. First,
> gcc -Wsuggest-attribute=const complains if it can deduce that an extern
> function is const but the function wasn't declared const.

Easy, then: either you live with this warning, or you don't
enable -Wsuggest-attribute=const.

Just silencing such a warning is no justification for this kind of
hideous code.

Using -Wsuggest-attribute=const every once in a while to see what could
be improved is probably a good idea, but we shouldn't blindly follow its
suggestions.


        Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]