Re: [Emacs-diffs] xwidget 9fe732a 2/2: Better changelog for xwidgets

[joakim]

Paul Eggert <address@hidden> writes:

> address@hidden wrote:
>> I'm guessing gnu indent breaks some Emacs build macrology.
>
> Yes, GNU indent doesn't understand DEFUN or DEFVAR_LISP.  Those, you
> need to reindent by hand.  Please see the patch in my earlier message
> for a good style for doing that, at:
>
> http://lists.gnu.org/archive/html/emacs-devel/2015-02/msg00012.html
>
> That patch also contains several other ideas worth considering.  If
> you don't understand any part of that patch please ask.
>

I'm working through the patch, but its a bit slow going.

There seemed to be some spurious diffs:
--- a/src/coding.c
+++ b/src/coding.c
@@ -5985,7 +5985,7 @@ bool
 raw_text_coding_system_p (struct coding_system *coding)
 {
   return (coding->decoder == decode_coding_raw_text
-         && coding->encoder == encode_coding_raw_text) ? true : false;
+         && coding->encoder == encode_coding_raw_text);
 }


And these:
-  next_element_from_stretch
+  next_element_from_stretch,
 #ifdef HAVE_XWIDGETS
-  ,next_element_from_xwidget
+  next_element_from_xwidget,

is it really correct to move the coma out of the ifdef?
I remember having trouble with that when I wrote the code originally.

My latest patch is in the xwidget_mvp branch, 

-- 
Joakim Verona