emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] scratch/check-declare e7e278c 1/2: check-declare.el (c


From: Stefan Monnier
Subject: Re: [Emacs-diffs] scratch/check-declare e7e278c 1/2: check-declare.el (check-declare-ext-errors): New defcustom.
Date: Fri, 13 Feb 2015 15:17:14 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux)

> +(defgroup check-declare nil
> +  "Check declare-function statements"
> +  :group 'tools)

I think you need a "." at the end of these docstrings.  C-u M-x
checkdoc-current-buffer might flag those things (along with others with
which I don't always agree ;-)

> +(defcustom check-declare-ext-errors nil
> +  "When non-nil, warn abount functions not found in :ext"
> +  :group 'check-declare)

This :group is redundant.  OTOH you need a ":type 'boolean".

> +  (cl-letf ((warning-prefix-function

Why cl-letf?


        Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]