Re: [PATCH] for review - making use of {EXEEXT} more uniform in makefiles.

[Michal Nazarewicz]

On Mon, Feb 23 2015, Pete Williamson <address@hidden> wrote:
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,7 @@
> +2015-02-20 Pete Williamson <address@hidden>

This email address disagrees with commit’s author.  It makes more sense
to use the same in both places, so which one do you prefer?

> +     * Makefile.in - Use the {EXEEXT} environment variable more uniformly

This should actually be:

+       * Makefile.in: Use the {EXEEXT} environment variable more uniformly

Note colon instead of a hyphen.

> +     to make sure that the emacs binary is used with the proper extension.
> +
>  2015-02-13  Jan Djärv  <address@hidden>
>  
>       * configure.ac: Set locallisppath to empty for NS self contained,

Actually you do not edit Makefile.in in the root directory so ChangeLog
entry in root ChangeLog is invalid.  Instead, you need to repeat the
entry in directories where you did modify Makefile.in files.  Yeah,
I know, I hate ChangeLog files too. ;)

Anyway, I have a commit ready with all that fixed, so no need to resend
a next one, just let me know which email address you want to use.

> diff --git a/leim/Makefile.in b/leim/Makefile.in
> index 573acf7..2ec03db 100644
> --- a/leim/Makefile.in
> +++ b/leim/Makefile.in
> @@ -47,7 +47,7 @@ unexport EMACSDATA EMACSDOC EMACSPATH
>  
>  # Which Emacs to use to convert TIT files to Emacs Lisp files,
>  # and generate the file leim-list.el.
> -EMACS = ../src/emacs
> +EMACS = ../src/emacs${EXEEXT}
>  
>  # How to run Emacs.
>  # Prevent any setting of EMACSLOADPATH in user environment causing problems.
> diff --git a/lib-src/Makefile.in b/lib-src/Makefile.in
> index d2705e7..6b5d379 100644
> --- a/lib-src/Makefile.in
> +++ b/lib-src/Makefile.in
> @@ -21,7 +21,7 @@
>  SHELL = @SHELL@
>  
>  # Following ../lisp/Makefile.in.
> -EMACS = ../src/emacs
> +EMACS = ../src/emacs${EXEEXT}
>  EMACSOPT = -batch --no-site-file --no-site-lisp
>  
>  # ==================== Things `configure' will edit ====================
> diff --git a/lisp/Makefile.in b/lisp/Makefile.in
> index e5cfc63..22d5ddc 100644
> --- a/lisp/Makefile.in
> +++ b/lisp/Makefile.in
> @@ -47,7 +47,7 @@ am__v_GEN_1 =
>  # We never change directory before running Emacs, so a relative file
>  # name is fine, and makes life easier.  If we need to change
>  # directory, we can use emacs --chdir.
> -EMACS = ../src/emacs
> +EMACS = ../src/emacs${EXEEXT}
>  
>  # Command line flags for Emacs.
>  

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michał “mina86” Nazarewicz    (o o)
ooo +--<address@hidden>--<xmpp:address@hidden>--ooO--(_)--Ooo--