Re: [Emacs-diffs] master 4fabcbf: Fix debbugs#20240 part two (jit-lock error during `comment-dwim').

[Alan Mackenzie]

Hello, Stefan.

On Sat, Apr 04, 2015 at 09:56:56AM -0400, Stefan Monnier wrote:
> > -          (run-hook-with-args 
> > 'jit-lock-after-change-extend-region-functions
> > -                              start end old-len)
> > -          ;; Make sure we change at least one char (in case of deletions).
> > -          (setq jit-lock-end (min (max jit-lock-end (1+ start)) 
> > (point-max)))
> > -          ;; Request refontification.
> > -          (put-text-property jit-lock-start jit-lock-end 'fontified nil))
> > +          (save-restriction
> > +       (widen)
> > +       (run-hook-with-args 'jit-lock-after-change-extend-region-functions
> > +                           start end old-len)
> > +       ;; Make sure we change at least one char (in case of deletions).
> > +       (setq jit-lock-end (min (max jit-lock-end (1+ start)) (point-max)))
> > +       ;; Request refontification.
> > +       (put-text-property jit-lock-start jit-lock-end 'fontified nil)))

> Huh.. no, I said that widening during the call to
> jit-lock-after-change-extend-region-functions was wrong.  The widening
> should only be around the put-text-property.

Sorry, misunderstanding there.  I'll change it (just as soon as I can
build).

>         Stefan

-- 
Alan Mackenzie (Nuremberg, Germany).