emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] master c5e89be: On C-y, stop some text property entrie


From: Alan Mackenzie
Subject: Re: [Emacs-diffs] master c5e89be: On C-y, stop some text property entries being written into buffer-undo-list
Date: Sat, 25 Apr 2015 20:53:34 +0000
User-agent: Mutt/1.5.23 (2014-03-12)

Hello, Stefan.

On Wed, Apr 22, 2015 at 10:34:20AM -0400, Stefan Monnier wrote:
> > +  (with-silent-modifications
> > +    (let ((inhibit-read-only t))
> > +      (dolist (handler yank-handled-properties)
> > +   (let ((prop (car handler))
> > +         (fun  (cdr handler))
> > +         (run-start start))
> > +     (while (< run-start end)
> > +       (let ((value (get-text-property run-start prop))
> > +             (run-end (next-single-property-change
> > +                       run-start prop nil end)))
> > +         (funcall fun value run-start run-end)

> Running the hook functions within with-silent-modifications sounds
> dangerous since they may make modifications which shouldn't be ignored
> (only the hooks can know).

> > +      (if (eq yank-excluded-properties t)
> > +     (set-text-properties start end nil)
> > +   (remove-list-of-text-properties start end yank-excluded-properties)))))

> This is the part that needs to be wrapped.

Sorry about that.  I've corrected it now.

>         Stefan

-- 
Alan Mackenzie (Nuremberg, Germany).



reply via email to

[Prev in Thread] Current Thread [Next in Thread]