emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] switch to file buffer from command line args regardless of `


From: Stefan Monnier
Subject: Re: [PATCH] switch to file buffer from command line args regardless of `initial-buffer-choice'
Date: Wed, 20 May 2015 14:36:48 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux)

>> After it's finished processing the command line args, it switches to the
>> buffer `initial-buffer-choice'. It does not open the startup screen if
>> `initial-buffer-choice' is non-nil, and it does not switch to any files.
>> It will open *Buffers List* if three or more files are given to it.
>> 
>> The behavior with my patch: If Emacs is given one file arg, it's opened
>> alongside `initial-buffer-choice'.

Hmm... shouldn't it just display that file's buffer and ignore
initial-buffer-choice?  Wait, I see the doc says:

   displayed.  If ‘initial-buffer-choice’ is non-‘nil’, then if you specify
   any files on the command line, Emacs still visits them, but does not
   display them initially.

So I guess no, we shouldn't ignore initial-buffer-choice when there are
files specified on the command line.  So your patch will require
updating the doc, but I think the behavior it provides is good.

>> If Emacs is given two or more file args, then it will display
>> `initial-buffer-choice' and *Buffer List*, which is consistent with
>> the current behavior when `initial-buffer-choice' is nil and Emacs is
>> given more files than it can display.

Sounds good.

>> Thanks in advance for the review!

You're welcome.  Feel free to install it.
I hope my review wasn't too prompt, tho,


        Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]