Re: [elpa] master 54ced08 3/3: Merge remote-tracking branch 'ztree/master'

[Alexey Veretennikov]

Hi,

Thanks for comments, I've updated the code to use lexical-binding, 
updated remaining function names and removed (redundant) 
newline-and-begin, replacing it with (insert "\n").

Br,
/Alexey

On 13/06/15 16:23, Stefan Monnier wrote:
> > -;; Compatibility: GNU Emacs GNU Emacs 24.x
> > +;; Compatibility: GNU Emacs 24.x
> So is it OK if I change those files to use lexical-binding?
>
> >   (defun newline-and-begin ()
> >     "Move a point to the beginning of the next line."
> > -  (newline)
> > +  (insert "\n")
> >     (beginning-of-line))
> The beginning-of-line can be removed as well (at which point you're
> better off removing newline-and-begin altogether and simply replace every
> call by (insert "\n")).
> One more thing: I see that ztree-util.el defines several functions (such
> as the one here) without a "ztree-" prefix.  It would be good to fix this.
>
>
>          Stefan