Re: [Emacs-diffs] master 0245cc3: Improve accessibility of window dividers. (Bug#20183)

[martin rudalics]

>> +(defgroup window-divider nil
> [...]
>> +(defcustom window-divider-mode nil
> [..]
>> +  :group 'window-divider
>
> This :group is redundant since it refers to the last created group.

Interesting.  Is this documented somewhere?

>> +(define-minor-mode window-divider-mode
> [...]
>> +  :group 'window-divider
>> +  :global t
>> +  :variable (window-divider-mode
>> +             . (lambda (value)
>> +                 (frame--window-divider-mode-set-and-apply
>> +                  (and value
>> +                       (or frame--window-divider-previous-mode
>> +                           (default-value 'window-divider-mode)
>> +                           'right-only))))))
>
> I'd rather not abuse the (GETTER . SETTER) here.  This is only really
> needed for those cases where the value of the mode is neither kept in
> a global var nor a buffer-local var (e.g. it's kept in a window or frame
> parameter instead).
>
> So, we should drop :variable, which will also let us drop the
> separate defcustom.

You mean the defcustom for `window-divider-mode'?  Then I completely
miss you.  Where would I specify the permitted values?

martin