unsolicited patch to image-mode.el -- "fit to window"

[Greg Minshall]

hi.  the following patch, from the emacs-24 branch, adds an
(image-transform-fit-to-window) to imagemagick mode, similar to
(image-transform-fit-to-width) and (image-transform-fit-to-height).
and, similar to those, a "Fit to Window" menu item.  basically, you get
the smaller of the (image-transfer-fit-to-height) and
(image-transfer-fit-to-width) (which is typically what i want when using
either of those two functions).

(i also have a much smaller patch to image.el which increases the chance
of using imagemagick mode (as opposed to, e.g., jpeg mode) on an image
file.  i'm happy to submit it if there's any interest.)

apologies if there is any protocol i'm missing; i'm a new kid in town.

cheers, Greg Minshall

ps -- details: possibly i went overboard in the lambda's below...
----
diff --git a/lisp/image-mode.el b/lisp/image-mode.el
index 2ed7fbe..8811c72 100644
--- a/lisp/image-mode.el
+++ b/lisp/image-mode.el
@@ -385,6 +385,9 @@ call."
        ["Fit to Window Width" image-transform-fit-to-width
         :visible (eq image-type 'imagemagick)
         :help "Resize image to match the window width"]
+       ["Fit to Window" image-transform-fit-to-window
+        :visible (eq image-type 'imagemagick)
+        :help "Resize image to fit in the window"]
        ["Rotate Image..." image-transform-set-rotation
         :visible (eq image-type 'imagemagick)
         :help "Rotate the image"]
@@ -895,6 +898,7 @@ Its value should be one of the following:
  - nil, meaning no resizing.
  - `fit-height', meaning to fit the image to the window height.
  - `fit-width', meaning to fit the image to the window width.
+ - `fit-window', meaning to fit the image to the window.
  - A number, which is a scale factor (the default size is 1).")
 
 (defvar image-transform-scale 1.0
@@ -1007,17 +1011,18 @@ of a rotated image."
   (when (and (not (numberp image-transform-resize))
             (boundp 'image-type)
             (eq image-type 'imagemagick))
-    (let ((size (image-display-size (image-get-display-property) t)))
-      (cond ((eq image-transform-resize 'fit-width)
-            (cl-assert (= (car size)
-                       (- (nth 2 (window-inside-pixel-edges))
+    (let ((size (image-display-size (image-get-display-property) t))
+          (width (- (nth 2 (window-inside-pixel-edges))
                           (nth 0 (window-inside-pixel-edges))))
-                    t))
+          (height (- (nth 3 (window-inside-pixel-edges))
+                          (nth 1 (window-inside-pixel-edges)))))
+      (cond ((eq image-transform-resize 'fit-width)
+            (cl-assert (= (car size) width) t))
            ((eq image-transform-resize 'fit-height)
-            (cl-assert (= (cdr size)
-                       (- (nth 3 (window-inside-pixel-edges))
-                          (nth 1 (window-inside-pixel-edges))))
-                    t))))))
+            (cl-assert (= (cdr size) height) t) )
+           ((eq image-transform-resize 'fit-window)
+            (cl-assert (or (= (car size) width)
+                            (= (cdr size) height)) t))))))
 
 (defun image-transform-properties (spec)
   "Return rescaling/rotation properties for image SPEC.
@@ -1032,7 +1037,26 @@ compiled with ImageMagick support."
            (/= image-transform-rotation 0.0))
     ;; Note: `image-size' looks up and thus caches the untransformed
     ;; image.  There's no easy way to prevent that.
-    (let* ((size (image-size spec t))
+    (let* ((size (image-size spec t))   ; (car size) == width;
+                                        ; (cdr size) == height
+           (ifwidth (lambda () 
+                      (image-transform-fit-width
+                       (car size) (cdr size)
+                       (- (nth 2 (window-inside-pixel-edges))
+                          (nth 0 (window-inside-pixel-edges))))))
+           (ifheight (lambda ()
+                       (let ((res (image-transform-fit-width
+                                   (cdr size) (car size)
+                                   (- (nth 3 (window-inside-pixel-edges))
+                                      (nth 1 (window-inside-pixel-edges))))))
+                         (cons (cdr res) (car res)))))
+           (ifwindow (lambda ()
+                       (let ((ifw (funcall ifwidth))
+                             (ifh (funcall ifheight)))
+                         (if (< (/ (float (car ifw)) (car size))
+                                (/ (float (cdr ifh)) (cdr size)))
+                             ifw
+                           ifh))))
           (resized
            (cond
             ((numberp image-transform-resize)
@@ -1040,16 +1064,11 @@ compiled with ImageMagick support."
                (setq image-transform-scale image-transform-resize)
                (cons nil (floor (* image-transform-resize (cdr size))))))
             ((eq image-transform-resize 'fit-width)
-             (image-transform-fit-width
-              (car size) (cdr size)
-              (- (nth 2 (window-inside-pixel-edges))
-                 (nth 0 (window-inside-pixel-edges)))))
+              (funcall ifwidth))
             ((eq image-transform-resize 'fit-height)
-             (let ((res (image-transform-fit-width
-                         (cdr size) (car size)
-                         (- (nth 3 (window-inside-pixel-edges))
-                            (nth 1 (window-inside-pixel-edges))))))
-               (cons (cdr res) (car res)))))))
+              (funcall ifheight))
+             ((eq image-transform-resize 'fit-window)
+              (funcall ifwindow)))))
       `(,@(when (car resized)
            (list :width (car resized)))
        ,@(when (cdr resized)
@@ -1081,6 +1100,14 @@ ImageMagick support."
   (setq image-transform-resize 'fit-width)
   (image-toggle-display-image))
 
+(defun image-transform-fit-to-window ()
+  "Fit the current image to the width of the current window.
+This command has no effect unless Emacs is compiled with
+ImageMagick support."
+  (interactive)
+  (setq image-transform-resize 'fit-window)
+  (image-toggle-display-image))
+
 (defun image-transform-set-rotation (rotation)
   "Prompt for an angle ROTATION, and rotate the image by that amount.
 ROTATION should be in degrees.  This command has no effect unless