Re: [PATCH] Make emacsclientw -a usable

[Eli Zaretskii]

> From: Evgeny Fraimovitch <address@hidden>
> Date: Sat, 18 Jul 2015 22:25:31 +0000
> 
> Currently the emacsclientw (the non-console version of Win32 emacs client) 
> pops
> up a modal message box if emacs server is not running even if there is an
> alternate specified. This makes the -a option (with or without an argument)
> somewhat useless, since the user is greeted by a modal message box,
> interrupting the workflow.
> The attached patch supresses the modal message box (only in Win32 and only in
> the non-console client) if there is an alternate editor specified - the user
> will only get an error message if the alternative fails too.
> 
> The patch is produced against today's emacs master.

Thanks.

> --- a/lib-src/emacsclient.c
> +++ b/lib-src/emacsclient.c
> @@ -968,7 +968,14 @@ set_tcp_socket (const char *local_server_file)
>    /* Set up the socket.  */
>    if (connect (s, (struct sockaddr *) &server, sizeof server) < 0)
>      {
> -      sock_err_message ("connect");
> +      /*Since we have an alternate to try out this is not an error yet
> +     popping out a modal dialog at this stage would make -a option totally
> +     useless for emacsclientw - the user will still get an error message
> +     if the alternate editor fails*/
> +#ifdef WINDOWSNT
> +      if(!(w32_window_app() && alternate_editor))
> +#endif
> +     sock_err_message ("connect");
>        return INVALID_SOCKET;
>      }

What about the other call to sock_err_message in that function,
doesn't it need to be handled the same way in emacsclientw?