emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Suggestion to have highlight related bindings consistent between sea


From: Kaushal
Subject: Re: Suggestion to have highlight related bindings consistent between search-map and hi-lock-map
Date: Wed, 29 Jul 2015 02:00:13 +0000

Hey everyone,

It looks like the consensus is that it would be fine to remove the "C-xw" as the same commands are also bound in the `search-map' with "M-sh" binding prefix. The added benefit is that "C-xw" binding can be used for something else in future.

This is the first time submitting a patch to emacs. So here it is:

From bed743a154eafbda0c716fbec4c97a58bb973a0f Mon Sep 17 00:00:00 2001
From: Kaushal Modi <address@hidden>
Date: Tue, 28 Jul 2015 21:38:37 -0400
Subject: [PATCH] Remove the "C-xw" bindings from hi-lock-map

---
 etc/NEWS        |  3 +++
 lisp/hi-lock.el | 11 +----------
 2 files changed, 4 insertions(+), 10 deletions(-)

diff --git a/etc/NEWS b/etc/NEWS
index 5bb7a00..f3a9e9d 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -289,6 +289,9 @@ standards.
 
 * Changes in Specialized Modes and Packages in Emacs 25.1
 
+** The C-xw bindings are removed from hi-lock.el as the same commands
+   are bound to the `search-map' in bindings.el
+
 ** Prog mode has some support for multi-mode indentation.
 See `prog-indentation-context' and `prog-widen'.
 
diff --git a/lisp/hi-lock.el b/lisp/hi-lock.el
index 0255585..d648e30 100644
--- a/lisp/hi-lock.el
+++ b/lisp/hi-lock.el
@@ -272,16 +272,7 @@ a library is being loaded.")
     map)
   "Menu for hi-lock mode.")
 
-(defvar hi-lock-map
-  (let ((map (make-sparse-keymap "Hi Lock")))
-    (define-key map "\C-xwi" 'hi-lock-find-patterns)
-    (define-key map "\C-xwl" 'highlight-lines-matching-regexp)
-    (define-key map "\C-xwp" 'highlight-phrase)
-    (define-key map "\C-xwh" 'highlight-regexp)
-    (define-key map "\C-xw." 'highlight-symbol-at-point)
-    (define-key map "\C-xwr" 'unhighlight-regexp)
-    (define-key map "\C-xwb" 'hi-lock-write-interactive-patterns)
-    map)
+(defvar hi-lock-map (make-sparse-keymap "Hi Lock")
   "Key map for hi-lock.")
 
 ;; Visible Functions
-- 
1.9.2


On Sun, Jul 19, 2015 at 4:00 AM Vaidheeswaran C <address@hidden> wrote:
On Sunday 12 July 2015 09:55 PM, Eli Zaretskii wrote:
>> From: Vaidheeswaran C <address@hidden>
>> > Date: Sun, 12 Jul 2015 21:03:48 +0530
>> >
>> > On Sunday 12 July 2015 08:45 PM, Eli Zaretskii wrote:
>>> > > Could you please make sure your messages are sent/received only once
>>> > > each?  I see between 2 to 3 identical messages each time you post
>>> > > something, both here and on help-gnu-emacs.
>> >
>> > Ok.  I am on a flaky connection and sometimes Icedove leaves me confused
>> > on whether or not it did my bidding.
>> >
>> > Are you sure it is "each time"...?
> Yes.

Goodbye to this and other sister lists.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]