emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 397e316: Add option `calendar-weekend-days'


From: Glenn Morris
Subject: Re: master 397e316: Add option `calendar-weekend-days'
Date: Tue, 04 Aug 2015 11:43:42 -0400
User-agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/)

It's no problem, don't worry about it.

Adding a missing commit message to a later commit, like in 4e1bdd44,
where you added a commit log for lisp/calendar/calendar.el, which wasn't
changed at all in that change, isn't the right way to correct things
though. It just causes confusion when reading the git log, and now there
will be three entries for this change in the generated ChangeLog. What
you are supposed to do is (from admin/notes/repo) run 'make
change-history' (or wait till Sunday when that happens automatically),
then edit ChangeLog.2 to correct it and commit it. Feel free to correct
any of the docs if there was something that would have made this stuff
clearer to you. (You're not the first person to edit ChangeLog.2 by hand.)

Wrt doc/emacs/calendar.texi, you're missing a final ".". at the end of
the sentence you added. (I'm not sure this was worth adding, since the
header faces aren't even mentioned in the manual. Not everything needs
to be. Which calendar systems even have something other than two
consecutive weekend days?)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]