[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [elpa] master b843370: * packages/other-frame-window/other-frame-win
From: |
Stephen Leake |
Subject: |
Re: [elpa] master b843370: * packages/other-frame-window/other-frame-window.el: New single-file package. |
Date: |
Sat, 15 Aug 2015 12:39:39 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (windows-nt) |
Stefan Monnier <address@hidden> writes:
>> * packages/other-frame-window/other-frame-window.el: New single-file
>> package.
>
> Thanks Stephen. The auto-build of the package failed because it didn't
> follow the ";;; name --- desc" convention, so I fixed it.
Sorry about that.
> And while
> I was there I made a bunch of other changes. Please take a look at
> them.
Thanks, looks good.
I have a couple questions:
In `ofw-transient-map', you wrote:
;; FIXME: This is basically the union of the default C-x 4 and C-x 5
;; keymaps in Emacs-25.
Is the point of this FIXME: that eventually this could replace the C-x 4
and C-x 5 keymaps?
In ofw-display-buffer-other-window, you added a FIXME about being
careful with display-buffer-overriding-action; that was an oversite,
I'll fix it.
In `other-frame-window-mode':
- I agree :lighter can be removed.
- Why is (remove-hook 'pre-command-hook #'ofw--reset-prefix) before the
'if', instead of in the else branch?
--
-- Stephe
- Re: [elpa] master b843370: * packages/other-frame-window/other-frame-window.el: New single-file package., Stefan Monnier, 2015/08/14
- Re: [elpa] master b843370: * packages/other-frame-window/other-frame-window.el: New single-file package.,
Stephen Leake <=
- Re: [elpa] master b843370: * packages/other-frame-window/other-frame-window.el: New single-file package., Stefan Monnier, 2015/08/15
- Re: [elpa] master b843370: * packages/other-frame-window/other-frame-window.el: New single-file package., Kaushal, 2015/08/17
- Re: [elpa] master b843370: * packages/other-frame-window/other-frame-window.el: New single-file package., Stefan Monnier, 2015/08/17
- Re: [elpa] master b843370: * packages/other-frame-window/other-frame-window.el: New single-file package., Stephen Leake, 2015/08/17
- Re: [elpa] master b843370: * packages/other-frame-window/other-frame-window.el: New single-file package., Stefan Monnier, 2015/08/18
- Re: [elpa] master b843370: * packages/other-frame-window/other-frame-window.el: New single-file package., Stephen Leake, 2015/08/18
- Re: [elpa] master b843370: * packages/other-frame-window/other-frame-window.el: New single-file package., Stefan Monnier, 2015/08/19