Re: [Emacs-diffs] master c24a067: message.el: Silent the byte compiler

[Stefan Monnier]

> +(eval-and-compile
> +  (if (featurep 'emacs)
> +      (progn
> +     (defalias 'message-delete-overlay 'delete-overlay)
> +     (defun message-kill-all-overlays ()
> +       (mapcar #'delete-overlay (overlays-in (point-min) (point-max))))
> +     (defalias 'message-make-overlay 'make-overlay)
> +     (defalias 'message-overlay-get 'overlay-get)
> +     (defalias 'message-overlay-put 'overlay-put)
> +     (defalias 'message-overlays-in 'overlays-in)
> +     (defalias 'message-window-inside-pixel-edges
> +       'window-inside-pixel-edges))
> +    (defun message-kill-all-overlays ()
> +      (map-extents (lambda (extent ignore) (delete-extent extent))))
> +    (defalias 'message-window-inside-pixel-edges 'ignore)))

[ I understand this code was only moved and is not new.  ]

BTW, the above makes no sense to me: e.g. message-overlay-get is never
defined to anything else than overlay-get.  So, under Emacs it gets
defined to overlay-get and under XEmacs it stays undefined (and hence
can't be used).  Why bother?  Why not just call overlay-get directly?
When would it be preferable to use message-overlay-get over overlay-get?


        Stefan