emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/3] lisp/mpc.el (mpc--proc-connect): use file-name-absolute-


From: Stefan Monnier
Subject: Re: [PATCH 3/3] lisp/mpc.el (mpc--proc-connect): use file-name-absolute-p
Date: Mon, 07 Sep 2015 21:16:16 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux)

> -    (when (string-prefix-p "/" host)    ;FIXME: Use file-name-absolute-p?
> +    (when (file-name-absolute-p host)
> +      ;; Expand file name because `file-name-absolute-p'
> +      ;; considers paths beginning with "~" as absolute
> +      (setq host (expand-file-name host))

So do you think using file-name-absolute-p is better?
I left it as a FIXME, because I simply didn't know the answer.

If you set $MPD_HOST to "~/.mpdsocket" do other MPD clients handle
it correctly?

What about under w32?


        Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]