emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Backslash cleanup introduced bug [284c470e 9/17]


From: Paul Eggert
Subject: Re: Backslash cleanup introduced bug [284c470e 9/17]
Date: Fri, 18 Sep 2015 09:41:23 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0

On 09/18/2015 05:34 AM, Wilson Snyder wrote:
One of your
cleanups broke the verilog-mode.el package regressions.


Thanks for catching that. I think you're referring to 753fbfbe, not to 284c470e as the Subject: line says. 284c470e was intended to not change behavior. 753fbfbe was intended to fix behavior, but obviously I messed up in that instance (and thanks for fixing it). I now see that I also misclassified a few changes in 284c470e, as they actually did affect behavior (e.g., this change in verilog-mode.el:

-                (re-search-backward "/\*")
+                (re-search-backward "/\\*")

), but I think these misclassified changes all fixed bugs so it should be OK.

One other thing. In 284c470e I tried to leave bugs alone when in doubt. That is, although there are undoubtedly still some bugs related to backslashes, when in doubt I left behavior the same as it was before. For example, lisp/net/tramp-adb.el has this:

(defcustom tramp-adb-prompt
"^\\(?:[[:digit:]]*|?\\)?\\(?:[[:alnum:]\e;address@hidden:alnum:]]*[^#\\$]*\\)?[#\\$][[:space:]]"

and both instances of \\$ should probably be just $. I wasn't sure, though, so I left them alone.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]