[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] master acfb5cd: Improve XEmacs compatibility of Tramp
From: |
Michael Albinus |
Subject: |
Re: [Emacs-diffs] master acfb5cd: Improve XEmacs compatibility of Tramp |
Date: |
Sun, 04 Oct 2015 20:12:46 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) |
Stefan Monnier <address@hidden> writes:
>> + ;; `directory-listing-before-filename-regexp' does not exist in
>> + ;; XEmacs. Since we use it only in tramp-adb.el, it doesn't harm to
>> + ;; declare it here.
>> + (unless (boundp 'directory-listing-before-filename-regexp)
>> + (defvar directory-listing-before-filename-regexp nil))
>
> Why not do
>
> (defvar directory-listing-before-filename-regexp)
>
> at top-level, which AFAIK works in all emacsen and is less harmful?
I've tried this first. XEmacs denies to cooperate.
>> +(autoload 'locate-dominating-file "files")
>> +(autoload 'tramp-compat-replace-regexp-in-string "tramp-compat")
>
> IIUC it's one of the best ways to silence the XEmacs byte-compiler, but
> it's a bit dangerous. So I suggest the patch below instead,
I'm just collecting my baggage for being offline for about a week. I'll
check when I'm back.
> Stefan
Best regards, Michael.