Re: [ELPA] New package: beacon

[Kaushal Modi]

OK, I think I need to reenable fci-mode at the end of beacon--dec. It seems to sort of work, just that the fci-mode gets re-enabled too soon, slightly before the beacon trails finish vanishing.

--
Kaushal Modi

On Thu, Oct 15, 2015 at 5:37 PM, Kaushal Modi <address@hidden> wrote:

This gif shows the problem with fci-mode enabled: http://i.imgur.com/G2ojtKc.gifv

That vertical line on the right is what the Fill Column Indicator package is inserting. With that persistently enabled, you can see that it messes up the beacon.. the cursor keeps on jumping to the set column.

I tried this to disable fci at the right time:

(defun beacon--shine ()

  "Shine a beacon at point."

  (setq-local sanityinc/fci-mode-suppressed fci-mode)

  (when fci-mode

    (turn-off-fci-mode))

  (let ((colors (beacon--color-range)))

    (save-excursion

      (while colors

        (if (looking-at "$")

            (progn

              (beacon--after-string-overlay colors)

              (setq colors nil))

          (beacon--colored-overlay (pop colors))

          (forward-char 1))))))

But I cannot figure out where to reenable it.. it didn't work if I tried to renable at the end of beacon--shine or beacon-blink.

--
Kaushal Modi

On Thu, Oct 15, 2015 at 5:27 PM, Artur Malabarba <address@hidden> wrote:

2015-10-15 18:33 GMT+01:00 Kaushal Modi <address@hidden>:

BTW, I just tried it out and it looks great! I like that meteor trail effect :)

I now just need to figure out how to make it play nice with fci-mode.

If a beacon pre/post hook is available, I can disable/enable fci-mode in there.

Before I push this tomorrow there'll be a way to conditionally avoid blinking. Would that help? What's fci-mode like and why does it conflict?