emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Add shell-quasiquote.


From: Kai Großjohann
Subject: Re: [PATCH] Add shell-quasiquote.
Date: Sat, 31 Oct 2015 18:03:36 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (darwin)

Random832 <address@hidden> writes:

> Speaking of Tramp, what if the local shell is not the same as the
> remote shell? And I don't see how the commands it runs "require a
> bournish shell" at all. they require that the commands themselves
> exist, but that's nothing to do with the shell.

In tramp-do-directory-files-and-attributes-with-stat, it uses "2>/dev/null"
which I believe does not work in csh.  I think there are other similar
subtleties.

A more obvious thing is that Tramp sets PS1 and csh doesn't know about PS1.

> It even has a TODO item:
>
> ;; * Rewrite `tramp-shell-quote-argument' to abstain from using
> ;;   `shell-quote-argument'.
>
> So much for not reinventing the wheel.

tramp-shell-quote-argument let-binds system-type to make
shell-quote-argument do the intended thing.  This is iffy.
shell-quote-argument is documented to do the right thing for the local
system, and who knows if tomorrow it still uses system-type to perform
that check?

Kai




reply via email to

[Prev in Thread] Current Thread [Next in Thread]