emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Font related crash?


From: martin rudalics
Subject: Re: Font related crash?
Date: Fri, 06 Nov 2015 12:26:11 +0100

> It can't, but later we have this:
>
>    FRAME_DISPLAY_INFO (f)->n_fonts++;
>    if (FRAME_DISPLAY_INFO (f)->n_fonts == 1)
>      {
>        FRAME_SMALLEST_CHAR_WIDTH (f) = min_width;
>        FRAME_SMALLEST_FONT_HEIGHT (f) = height;
>        f->fonts_changed = 1;
>      }
>    else
>      {
>        if (FRAME_SMALLEST_CHAR_WIDTH (f) > min_width)
>    FRAME_SMALLEST_CHAR_WIDTH (f) = min_width, f->fonts_changed = 1;
>        if (FRAME_SMALLEST_FONT_HEIGHT (f) > height)
>    FRAME_SMALLEST_FONT_HEIGHT (f) = height, f->fonts_changed = 1;
>      }
>
> If, for some reason, n_fonts is not zero,

Indeed.  Though such behavior would be unforeseen and probably buggy
too.

> and
> FRAME_SMALLEST_CHAR_WIDTH is zero, this will not do anything, and will
> leave FRAME_SMALLEST_CHAR_WIDTH at zero.
>
[...]
>>   > Or maybe when we create a frame we should simply initialize
>>   > FRAME_SMALLEST_CHAR_WIDTH to 1 (and similarly with
>>   > FRAME_SMALLEST_FONT_HEIGHT).
>>
>> Or have these macros never provide zero.  My only concern is that this
>> might hide some underlying problem.
>
> Yes, but which one?  Did you try reproducing this on X?

I don't have these fontsets.

martin



reply via email to

[Prev in Thread] Current Thread [Next in Thread]