Re: [Emacs-diffs] master ef75c3b: Optimize `file-equal-p' and `file-in-directory-p' in Tramp

[Michael Albinus]

Stefan Monnier <address@hidden> writes:

>> +  (when (string-equal
>> +     (file-remote-p (expand-file-name filename1))
>> +     (file-remote-p (expand-file-name filename2)))
>
> The above args to string-equal aren't always strings: why not use
> `equal' instead?
> (string-equal nil "nil") is non-nil, so I think the code will work
> correctly but only because file-remote-p should hopefully never return
> "nil".

file-remote-p never returns "nil". It returns either the remote prefix
of a file name (a string), or nil.

>         Stefan

Best regards, Michael.