emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] emacs-25 8ff888a: Improve fix for regex reentrancy abo


From: Ken Brown
Subject: Re: [Emacs-diffs] emacs-25 8ff888a: Improve fix for regex reentrancy abort
Date: Wed, 18 Nov 2015 11:31:58 -0500
User-agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0

On 11/16/2015 4:10 PM, Paul Eggert wrote:
branch: emacs-25
commit 8ff888a07d0500f1274723086469191aade0a33e
Author: Paul Eggert <address@hidden>
Commit: Paul Eggert <address@hidden>

     Improve fix for regex reentrancy abort

     Suggested by Stefan Monnier (Bug#21688).
     * src/syntax.c (update_syntax_table_forward):
     Remove recently-added PROPERTIZE arg, and assume it is true.
     All callers changed.
     * src/syntax.h (UPDATE_SYNTAX_TABLE_FORWARD_FAST):
     Invoke update_syntax_table directly.

The message-mode-propertize test fails after this commit.

$ make -C test/automated/ message-mode-tests

Test message-mode-propertize backtrace:
  #[0 "\303\304!r\211q\210\305\306\307\310\311!\312\"\313$\216\314\21
  ert--run-test-internal([cl-struct-ert--test-execution-info [cl-struc
  ert-run-test([cl-struct-ert-test message-mode-propertize nil #[0 "\3
  ert-run-or-rerun-test([cl-struct-ert--stats t [[cl-struct-ert-test m
  ert-run-tests(t #[385 "\306\307\"address@hidden
  ert-run-tests-batch(nil)
  ert-run-tests-batch-and-exit()
  command-line-1(("-L" ":../../../emacs-25/test/automated" "-l" "ert"
  command-line()
  normal-top-level()
Test message-mode-propertize condition:
    (ert-test-failed
     ((should
       (string= "here's an opener "
                (buffer-substring-no-properties ... ...)))
      :form
      (string= "here's an opener " "here's a sad face :-")
      :value nil))
   FAILED  1/1  message-mode-propertize

Ken




reply via email to

[Prev in Thread] Current Thread [Next in Thread]