emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: setq's with missing final arguments.


From: Alan Mackenzie
Subject: Re: setq's with missing final arguments.
Date: Sun, 22 Nov 2015 14:10:31 +0000
User-agent: Mutt/1.5.23 (2014-03-12)

Hello, Andreas.

On Sun, Nov 22, 2015 at 02:34:51PM +0100, Andreas Schwab wrote:
> David Kastrup <address@hidden> writes:

> > Presumably you mean that this afflicts both byte compiler and
> > interpreter.  But that's really beside the point and does not magically
> > make it a good idea.

> The byte-compiler is not for imposing coding style.

That is why I proposed issuing a warning, not an error.  In the actual
case I found, it was indeed an error.  

> If it is wrong for setq to accept implit nil then it should be changed
> in setq and only then in the byte-compiler.

I would be happy enough for a missing final argument to setq to be an
error.  But until that stage is reached, I think issuing a warning is
appropriate.  But I disagree with you about priorities: it is more
important to catch the violations in our compiled code than worry about
the interpreted version.

> Andreas.

> -- 
> Andreas Schwab, address@hidden
> GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
> "And now for something completely different."

-- 
Alan Mackenzie (Nuremberg, Germany).



reply via email to

[Prev in Thread] Current Thread [Next in Thread]