Re: Lisp watchpoints

[Eli Zaretskii]

> Date: Sun, 29 Nov 2015 14:40:57 -0500
> From: Noam Postavsky <address@hidden>
> Cc: Stefan Monnier <address@hidden>, John Wiegley <address@hidden>, 
> address@hidden
> 
> > The call to ARRAYELTS should be outside of the loop (for those poor
> > souls who run unoptimized builds most of the time).
> 
> Compiling the following shows gcc folds the constants even with -O0
> (also, notify_variable_watchers() should only be called for a few
> selected symbols so I don't think it would really slow things down
> very much).

That depends om your GCC version, and then there are -fFOO switches
that can control each specific optimizations.  And seeing that in the
code simply looks wrong, regardless.  So let's move it out, please.

> >> +  DEFVAR_INT ("set-redisplay-internal-watcher-number",
> >> +              Vset_redisplay_internal_watcher_number,
> >> +              doc: /* Internal watch function constant.  */);
> >> +  Vset_redisplay_internal_watcher_number = WATCHER_NUMBER_SET_REDISPLAY;
> >> +  make_symbol_constant (intern_c_string 
> >> ("set-redisplay-internal-watcher-number"));
> >
> > I'd prefer if all this were moved to window.c.  data.c has no business
> > with display-related issues.
> 
> Hmm, then how should we make the connection between watcher numbers
> and C function pointers? I think data.c should be in charge of that.

What connection?  I'm afraid I'm not following.

> > > Please also add a short notice for etc/NEWS.  Bonus points for adding
> > some tests.
> 
> Will do.

Thanks.