Re: why does make check run all tests?

[Phillip Lord]

Stephen Leake <address@hidden> writes:

> Michael Albinus <address@hidden> writes:
>
>> address@hidden (Phillip Lord) writes:
>>
>>> Should make check just not build incrementally? If you want to run
>>> everything unconditionally, then why not use
>>>
>>> make clean check
>>>
>>> Or am I missing something obvious? In which case, I will need to restore
>>> the old behaviour for make check and leave make check-maybe as is.
>>
>> "make check" is not intented to check, whether a *changed* file still
>> runs successfully. "make check" is intended to run a full regression
>> test over Emacs. Pls keep this functionality.

I've restored this functionality now (which I accidentally removed).

make check-maybe

is incremental as before, due also depends on the files being tested.


> Especially since the dependencies are not complete; elisp-mode-tests.el
> only depends on elisp-mode.el, not on the transitive require closure.

Strictly, yes, this is true, but then I think this is true of other
parts of the Emacs build -- elisp-mode.elc depends only on
elisp-mode.el (in the makefile), although, IIUC, elisp-mode.elc also
depends on cl-generic and it's macros. In practice, the dependencies I
have added make a reasonable guess, I think.

Still, your point is well made. I think both incremental and
unconditional tests need to be there.

Phil