emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: UP and DOWN with multi-line minibuffer history


From: David Kastrup
Subject: Re: UP and DOWN with multi-line minibuffer history
Date: Mon, 14 Dec 2015 17:41:21 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux)

Eli Zaretskii <address@hidden> writes:

>> From: David Kastrup <address@hidden>
>> Cc: Juri Linkov <address@hidden>,  address@hidden
>> Date: Mon, 14 Dec 2015 10:25:20 +0100
>>
>> >From simple.el:
>> 
>> (defun line-move (arg &optional noerror to-end try-vscroll)
>>   "Move forward ARG lines.
>> If NOERROR, don't signal an error if we can't move ARG lines.
>> TO-END is unused.
>> TRY-VSCROLL controls whether to vscroll tall lines: if either
>> `auto-window-vscroll' or TRY-VSCROLL is nil, this function will
>> not vscroll."
>> [...]
>>       (if (and line-move-visual
>>                ;; Display-based column are incompatible with goal-column.
>>                (not goal-column)
>> 
>
> I said "in the visual-line sense", and I meant it.  You are looking at
> the wrong part of the code; you should instead look at how
> line-move-visual calls vertical-motion passing it the value of
> temporary-goal-column.

I don't quite see why I should look at `line-move-visual' when
`line-move-visual' is never called by `line-move' when `goal-column' is
set and there is no other caller of `line-move-visual' in the Emacs code
base.

-- 
David Kastrup



reply via email to

[Prev in Thread] Current Thread [Next in Thread]