Eli Zaretskii <
address@hidden> schrieb am So., 20. Dez. 2015 um 16:48 Uhr:
> From: Philipp Stephani <address@hidden>
> Date: Sat, 19 Dec 2015 21:03:32 +0000
> Cc: address@hidden, address@hidden, address@hidden,
> address@hidden
>
> Here's another patch that replaces some of the custom error handling with
> signals. The signals will be immediately caught by the prologue, but some
> complexity and duplication is removed.
Thanks. Did you run the mod-test test suite,
yes
and did you make sure
that signaling an error from a module still reports the same
information and backtrace as before the change?
No, but I wouldn't know how the patch should change this. It only changes an implementation detail in the error reporting code of the module implementation itself.
If we wanted to check the backtrace, I think we should rather add a unit test for it.