emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] fix conv_lisp_to_sockaddr for AF_INET6 addresses


From: John Wiegley
Subject: Re: [PATCH] fix conv_lisp_to_sockaddr for AF_INET6 addresses
Date: Sun, 07 Feb 2016 12:52:02 -0500
User-agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/24.5 (darwin)

>>>>> David Edmondson <address@hidden> writes:

> When trying to test Lars' async-dns changes I encountered memory corruption
> whenever the addresses returned for a host included IPv6 addresses. This
> turns out to be a bug in the mainline code which is just more likely to be
> tickled by the async-dns changes because they convert addresses to lisp
> objects whenever `make-network-process' is called (the current code doesn't
> do that).

Lars, it's the discovery of bugs like this that lead me to conclude two
things:

 1. I'd like much more testing of this feature before we consider it for
    release.

 2. We need a suite of tests for this feature, because it makes a rather
    fundamental change, and I'd like some coverage to ensure that others
    working in similar areas won't break it in future.

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2



reply via email to

[Prev in Thread] Current Thread [Next in Thread]