Re: Asynchronous DNS

[Lars Ingebrigtsen]

Alain Schneble <address@hidden> writes:

>> With :nowait t now, inch/outch will never be zero here, because we've
>                  ^^^
> What do you mean by now?  I was referring to the async DNS resolve case.
>
>> crated the sockets, even if we haven't connected them...  So it seems
>> like it'll complete whatever it's doing even if those sockets aren't
>> connected.  Possibly.
>
> That's true for the previous non-async DNS code.  But with async DNS,
> the socket may not yet have been created.

Yeah, I was talking about the current (and async-dns) :nowait t code.
The :nowait 'immediate code, of course, has other paths.

If we just add blockers to these functions, then code that worked
perfectly well with :nowait t now will stop working (as well).

That's a regression we can't fix for out-of-tree usages of
make-network-process, so I'm back to thinking that we should not change
any of those functions, and :nowait t should work like it does today,
and if you want make-network-process to return before the socket has
been set up (i.e., :nowait 'immediate), then you have to wait until the
process is in state 'run before calling those functions.

I.e., I think we should merge async-dns into trunk as is.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no