emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Asynchronous DNS


From: Eli Zaretskii
Subject: Re: Asynchronous DNS
Date: Mon, 15 Feb 2016 05:41:23 +0200

> From: Alain Schneble <address@hidden>
> CC: Lars Ingebrigtsen <address@hidden>, <address@hidden>
> Date: Mon, 15 Feb 2016 01:14:51 +0100
> 
> Eli Zaretskii <address@hidden> writes:
> 
> >> From: Lars Ingebrigtsen <address@hidden>
> >> Cc: address@hidden,  address@hidden
> >> Date: Sun, 14 Feb 2016 18:01:39 +1100
> >> 
> >> The issue is losing asynchronicity.  A function that previously called
> >> 
> >> (progn
> >>   (make-network-stream ... :nowait t)
> >>   (set-process-coding-system ...))
> >> 
> >> would not block.  With the proposed blockers (unless we add fine-grained
> >> code to all the process function to only block if we haven't even done
> >> DNS yet), this code will block.  And that's a regression.
> >
> > If set-process-coding-system worked in the above snippet, it means it
> > doesn't need to block waiting for a fully capable process object.  If
> > it didn't work (as in signaled an error), then there's no regression.
> 
> set-process-coding-system, how it is currently implemented on master,
> requires valid infd/outfd, hence an initialized socket.
> make-network-process until now did initialize a socket also with :nowait
> t.  That is no longer the case in the feature/async-dns branch with the
> :nowait 'dns option, where make-network-stream returns without having
> initialized a socket.

Yes, I know.  So there's no regression, since the above snippet
doesn't work on the async-dns branch because set-process-coding-system
signals an error.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]