emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Showing the relevant part of a diff


From: Eli Zaretskii
Subject: Re: [PATCH] Showing the relevant part of a diff
Date: Fri, 19 Feb 2016 10:47:04 +0200

> From: "Herring, Davis" <address@hidden>
> Date: Fri, 19 Feb 2016 05:43:23 +0000
> +(defun diff-goto-line (file line column)
> +  "Go to the place in this diff producing LINE in FILE.

This first line should mention COLUMN as well.

> +If LINE (in the new version of FILE) is included, move to it and then
                                        ^^^^^^^^^^^
Included where?

> +COLUMN characters forward.  If it is absent, go to the first hunk
> +starting after LINE, or to the end if none does.

Why this fallback?  Would it make sense to just stay at the beginning?

> +    (unless rev2    ; remember the position in the or a current buffer

Typo in the comment.

Thanks.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]