[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master 0883e98 1/3: New functions for getting and setting image prop
|
From: |
Michael Heerdegen |
|
Subject: |
Re: master 0883e98 1/3: New functions for getting and setting image properties |
|
Date: |
Mon, 22 Feb 2016 14:15:39 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.0.91 (gnu/linux) |
Lars Ingebrigtsen <address@hidden> writes:
> Great! I'll rewrite those two getter/setter functions to be more
> setf-ey.
Looks ok. Nitpick: according to the doc of `gv-define-simple-setter',
to "preserve the semantics of setf" `image--set-property' should either
return the VALUE. Or use
(declare (gv-setter image--set-property t))
^
Hmm, this DTRT, though it's not documented in
(info "(elisp) Declare Form")
Will file a bug report...
Regards,
Michael.