emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] emacs-25 040e0d6: Fix 'toggle-save-place'


From: Eli Zaretskii
Subject: Re: [Emacs-diffs] emacs-25 040e0d6: Fix 'toggle-save-place'
Date: Thu, 25 Feb 2016 18:09:44 +0200

> From: Stefan Monnier <address@hidden>
> Cc: Eli Zaretskii <address@hidden>
> Date: Thu, 25 Feb 2016 08:44:37 -0500
> 
> > +;;;###autoload
> >  (defun toggle-save-place (&optional parg) ;FIXME: save-place-local-mode!
> 
> As can be seen in the comment, I think this name should be changed (and
> the implementation should use define-minor-mode), so I suggest we don't
> autoload this until we've fixed the naming.

It makes no sense not to autoload it, because then there's no way for
users to turn save-place in a single buffer.  Previously, users needed
to load saveplace.el to have the feature, so an autoload was not
needed.  But the changes which switched to save-place-mode invalidated
that paradigm, and created a deficiency, which I fixed.  (They also
broke the command, which I also fixed.)

I have nothing against having a local mode, but I don't have time to
work on this now, so patches are very welcome.

Thanks.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]