Re: emacs-25 b6b47AF: Properly encode/decode base64Binary data in SOAP

[Thomas Fitzsimmons]

Stefan Monnier <address@hidden> writes:

>>>> The interface does not return bytes, it returns a (half-)decoded lisp
>>>> form.
>>> My understanding is that it returns a structure whose leaves are
>>> all byte-strings because.
>> String values are returned as multibyte, e.g.:
>> (multibyte-string-p (cdr (assq 'severity (car (debbugs-get-status 22285)))))
>> => t
>> because parsing happens in a temporary buffer where
>> enable-multibyte-characters is set, and the string value is returned
>> unchanged.
>
> If these are undecoded, then I'd consider it a bug to return them as
> multibyte, indeed.  The temp buffer should probably be made unibyte.

See my response to Eli.

>> this nuance of the API.  Also, on the encoding side I think we should
>> force the caller to provide unibyte strings for base64Binary values.
>
> I'd let base64-encode-string make that decision, but it's just my own
> preference of bikeshed's color.

OK.

>> Is the attached patch OK for master and emacs-25?
>
> Looks OK to me for master.  I'll let others figure out if it's safe
> enough for `emacs-25'.

Andreas committed his change to base64Binary handling to both master and
emacs-25.  Whatever the decision regarding reverting it, those two
branches should have the same behavior.

Thomas